Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more state in RenderSceneBuffersRD #94388

Conversation

BastiaanOlij
Copy link
Contributor

Expose more state from our render scene buffers object that can be handy when writing compositor effects.

Note: some of these are needed to complete the motion blur plugin some contributors are working on. Would be good to add this into 4.3, should be pretty harmless.

@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Jul 15, 2024
@BastiaanOlij BastiaanOlij self-assigned this Jul 15, 2024
@BastiaanOlij BastiaanOlij requested review from a team as code owners July 15, 2024 11:35
@BastiaanOlij BastiaanOlij force-pushed the expose_more_methods_scene_buffers_rd branch from d850e43 to 9442eb8 Compare July 15, 2024 12:04
@clayjohn clayjohn modified the milestones: 4.3, 4.4 Jul 15, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Bumping to 4.4 since we want to release RC1 soon

@BastiaanOlij BastiaanOlij mentioned this pull request Jul 16, 2024
14 tasks
@BastiaanOlij
Copy link
Contributor Author

Seems fine to me. Bumping to 4.4 since we want to release RC1 soon

This is a blocker for the team that is working on motion vectors support in 4.3, seeing it is low impact I would like it considered for merging.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me as an exception to feature freeze, it's only exposing existing methods, and there's a confirmed use case for them in 4.3.

@akien-mga akien-mga modified the milestones: 4.4, 4.3 Jul 19, 2024
@akien-mga akien-mga merged commit 47e99d5 into godotengine:master Jul 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the expose_more_methods_scene_buffers_rd branch August 20, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants