-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more state in RenderSceneBuffersRD #94388
Expose more state in RenderSceneBuffersRD #94388
Conversation
d850e43
to
9442eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Bumping to 4.4 since we want to release RC1 soon
This is a blocker for the team that is working on motion vectors support in 4.3, seeing it is low impact I would like it considered for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me as an exception to feature freeze, it's only exposing existing methods, and there's a confirmed use case for them in 4.3.
Thanks! |
Expose more state from our render scene buffers object that can be handy when writing compositor effects.
Note: some of these are needed to complete the motion blur plugin some contributors are working on. Would be good to add this into 4.3, should be pretty harmless.