Fix empty region in AtlasTexture #94365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jul 17, 2024
AThousandShips
approved these changes
Jul 17, 2024
KoBeWi
force-pushed
the
every_single_time
branch
from
dfe7977 to
10da06a
Compare
AThousandShips
approved these changes
Jul 18, 2024
|
Thanks! |
|
@KoBeWi what do you think, should be any below-one values handled like this? Or at least in [0; 1] range. |
|
Looks like a problem with region property. The position can be Vector2, but the size has to be Vector2i. Rect2 nor Rect2i support that. Maybe we should just round it up. |
Same thoughts. Although I'm not sure how this will work with the region editor window. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtlasTexture supports empty region size, in which case the size of the base texture is supposed to be used. However it was implemented only partially - the size was used as size of the AtlasTexture, but not in the drawing code. This PR fixes that.
Testing: make Sprite2D with AtlasTexture where
regionhas size of 0.