GDScript: Restore support for Token::UNDERSCORE in identifiers
#94327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolonProduction
force-pushed
the
underscore_identifier
branch
2 times, most recently
from
71404bd to
539c107
Compare
HolonProduction
changed the title
Token::UDNDERSCORE in identifiersToken::UNDERSCORE in identifiers
|
I would like this feature in |
dalexeev
approved these changes
Jul 15, 2024
HolonProduction
force-pushed
the
underscore_identifier
branch
from
539c107 to
06e732c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94310
get_identifierused the token source before. With the introduction of the binary tokenizer this is handled differently, so we need to manually set the identifier onToken::UNDERSCORE.