Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note of loop_mode for custom_timeline to the NodeAnimation docs #94299

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jul 13, 2024

I have found that the behavior varies depending on the value of the actual Animation resource property.

However, this is an unavoidable problem due to the architecture design. I added a note to the documentation describing the cases where the problem occurs and the reasons why.

@TokageItLab TokageItLab added this to the 4.3 milestone Jul 13, 2024
@TokageItLab TokageItLab requested a review from a team July 13, 2024 03:54
@TokageItLab TokageItLab requested a review from a team as a code owner July 13, 2024 03:54
@akien-mga akien-mga modified the milestones: 4.3, 4.4 Jul 31, 2024
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 31, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this, either.

Also dedicating 3 lines to the same topic is excessive. Keep in mind each new line is separated into paragraphs in the class reference, that is, one more new line is added in the middle of these. This means each line tends to be roughly self-contained.
I don't like this behavior personally, as it conflicts with how GitHub Flavored Markdown does it, but it is what it is,

It should all be one line (maybe with well-placed [br] tags if it's okay to).
But still, watch out. This is an overwhelming amount of information to be seeing about a seemingly simple property in the class reference, let alone on the Inspector's tooltip.

@TokageItLab TokageItLab force-pushed the docs-override-loop-tree branch from a620925 to 819bbb2 Compare August 1, 2024 03:19
@TokageItLab
Copy link
Member Author

I rewrote it to leave only the important points, how about one?

@TokageItLab TokageItLab force-pushed the docs-override-loop-tree branch from 819bbb2 to 73d9ad9 Compare August 1, 2024 03:21
@TokageItLab TokageItLab force-pushed the docs-override-loop-tree branch from 1066e6f to dd32e2d Compare August 1, 2024 09:52
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 1, 2024
@akien-mga akien-mga removed topic:animation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 1, 2024
@akien-mga akien-mga merged commit 6519e2e into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants