Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expand/Collapse Branch right click option to remote scene view #94263

Merged

Conversation

Arnklit
Copy link
Contributor

@Arnklit Arnklit commented Jul 12, 2024

This adds the Expand/Collapse Branch option to the right click menu in the remote scene view.

godot.windows.editor.dev.x86_64_guzrqu7Fbs.mp4

Note: it feels like there is some room for improvement in the code for actions in the remote view. They are basically copies of functions in scene_tree_dock.cpp, but I'm not sure how this would best be refactored to be reused. Also the same functionality for Expanding/Collapsing a node also exists through "Ctrl+Shift+Click" on the expand arrow, but seems to have another code path than the one in scene_tree_dock.cpp.

@Arnklit Arnklit requested a review from a team as a code owner July 12, 2024 13:43
@AThousandShips AThousandShips added this to the 4.x milestone Jul 12, 2024
@JekSun97
Copy link
Contributor

Why do we need this? this only increases the menu, and the time it takes to find the right button

@Arnklit
Copy link
Contributor Author

Arnklit commented Jul 12, 2024

Why do we need this? this only increases the menu, and the time it takes to find the right button

If you are browsing or searching the remote scene it is very cumbersome to open all the levels manually and if you don't know about the hidden shortcut of Ctrl+Shift+Click you'll be stuck opening all of them manually.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 3, 2024
@akien-mga akien-mga merged commit 5a37454 into godotengine:master Sep 3, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an "Expand Branch" functionality to Remote Tree
4 participants