Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThorVG: Update to 0.14.2 #94258

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

capnm
Copy link
Contributor

@capnm capnm commented Jul 12, 2024

Fixed bugs related to Godot

  • Fixes SVG: Graphical objects stored in <defs> shouldn't be rendered directly.

Test SVG:
godot-test-svg_defs

Godot ... → master
image

Godot master + PR
image
image

We've tested this on a 64-bit system running Linux Debian Bookworm.

+ Fixes SVG: Graphical objects stored in <defs> shouldn't be rendered directly.
@capnm capnm requested a review from a team as a code owner July 12, 2024 11:03
@AThousandShips AThousandShips added this to the 4.x milestone Jul 12, 2024
@aaronfranke
Copy link
Member

Why is the color tone different in the screenshot?

SVG: #478cbf
Left: #579ecb
Right: #5997cd

@capnm
Copy link
Contributor Author

capnm commented Jul 13, 2024

Why is the color tone different in the screenshot?

SVG: #478cbf Left: #579ecb Right: #5997cd

The left picture in the hidden "devs" area comes from a collision animation that uses modulated colors. The eye color is also different.

image

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 17, 2024
@akien-mga akien-mga added bug and removed enhancement labels Jul 17, 2024
@akien-mga akien-mga merged commit 13dffe2 into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants