Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix black get_texture() on viewport in compatibility mode with HDR enabled #94233

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix black get_texture() on viewport in compatibility mode with HDR enabled #94233

merged 1 commit into from
Jul 18, 2024

Conversation

ChristopheClaustre
Copy link
Contributor

gl_type_cache is used mainly for texture to image conversion and need to be adjusted when HDR format is activated

@ChristopheClaustre
gl_type_cache is used mainly for texture to image conversion need to …
626106d 
…be adjusted for when HDR format is activated
@ChristopheClaustre ChristopheClaustre requested a review from a team as a code owner July 11, 2024 20:26
@akien-mga akien-mga added this to the 4.3 milestone Jul 11, 2024
@akien-mga akien-mga changed the title Fix black get_texture() on viewport in compatibility mode with HDR enabled Fix black get_texture() on viewport in compatibility mode with HDR enabled Jul 11, 2024
@akien-mga akien-mga requested a review from BastiaanOlij July 17, 2024 09:13
clayjohn
clayjohn approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@akien-mga akien-mga merged commit de27d3a into godotengine:master Jul 18, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@ChristopheClaustre ChristopheClaustre deleted the screenshot_compat_broken_with_hdr branch July 18, 2024 11:18
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Black get_texture() from viewport on desktop, works fine on mobile.
3 participants
@ChristopheClaustre @akien-mga @clayjohn