Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS project generation with SCons 4.8.0+ #94117

Merged

Conversation

mhilbrunner
Copy link
Member

@mhilbrunner mhilbrunner commented Jul 9, 2024

SCons 4.8.0+ again (like in 4.6.0, see #85357) changes this piece of code, as reported in #94090 (thanks for the detailed report!).

I tested this with SCons 4.6.0 and 4.8.0 and both successfully generate VS projects for me. Would appreciate if @SavFox could verify this as well.

Fixes #94090.

@mhilbrunner mhilbrunner added bug platform:windows topic:buildsystem cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 9, 2024
@mhilbrunner mhilbrunner added this to the 4.3 milestone Jul 9, 2024
@mhilbrunner mhilbrunner requested a review from a team as a code owner July 9, 2024 07:16
methods.py Outdated Show resolved Hide resolved
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 9, 2024
@mhilbrunner mhilbrunner force-pushed the fix-94090-vsproj-scons-4.8 branch from 0c52c1c to f682406 Compare July 9, 2024 07:55
@mhilbrunner
Copy link
Member Author

mhilbrunner commented Jul 9, 2024

@akien-mga Good catch, I just saw in the diff that they removed passing env in their own use, but we can indeed keep it for now. In any case, passing the parameters this way makes the code slightly less messy for now, I can adapt it if they change it further. :)

cCVqHor

@SavFox
Copy link

SavFox commented Jul 9, 2024

Dear @mhilbrunner, i clone you reposetory by git clone -b fix-94090-vsproj-scons-4.8 https://github.com/mhilbrunner/godot.git and make project for Visual Studio (scons platform=windows vsproj=yes). I was abl to create project on SCons v4.8.0.7. Thank you.

@akien-mga akien-mga merged commit 5514510 into godotengine:master Jul 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@mhilbrunner
Copy link
Member Author

@SavFox Thanks for testing, and thanks again for the great report :)

@mhilbrunner mhilbrunner deleted the fix-94090-vsproj-scons-4.8 branch July 9, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release platform:windows topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem to build godot vsproject on SCons 4.8.0
3 participants