Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix build error due to missing definition of Texture2D #94067

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

RandomShaper
Copy link
Member

For some reason, now I'm getting a compile error about Texture2D being an incomplete type when used in DisplayServerWindows::create_status_indicator(). This is a cure.

@RandomShaper RandomShaper added this to the 4.3 milestone Jul 8, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner July 8, 2024 08:43
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. In the header it's forward-declared by way of including servers/display_server.h, so each display server implementation is responsible for including it if they implement one of the APIs that use Texture2D.

@akien-mga akien-mga merged commit ec02d40 into godotengine:master Jul 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_build branch July 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants