-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix goto line issues in code editor #94002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, one small note inline.
state["column"] = 0; | ||
state["scroll_position"] = members_overview->get_item_metadata(p_idx); | ||
se->set_edit_state(state); | ||
CodeTextEditor *cte = se->get_code_editor(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I like the idea of the ScriptEditorPlugin
interacting with the code editor directly, would prefer changing the API (combine them with a new arg?) or as above cast to the specific type.
Updated to use a cast, as elsewhere in |
Thanks! |
goto_line_selection
)goto_line
).I did not change the goto line popup since I have another PR about that #91388.
Removed the
p_with_error
argument since it isn't used. There are some other uses ofgoto_line
that could use the new column argument, but I'll leave that for another PR.