-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GDScript] Fix get_argument_count
for lambda Callable
s
#93964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AThousandShips
commented
Jul 5, 2024
- Fixes: get_argument_count() on Callable class reporting nested lamda calls as additional arguments. #93952
AThousandShips
changed the title
[GDScript] Fix
[GDScript] Fix Jul 5, 2024
get_argument_count
for lambda Callables
get_argument_count
for lambda Callable
s
akien-mga
reviewed
Jul 5, 2024
modules/gdscript/tests/scripts/runtime/features/lambda_bind_argument_count.out
Outdated
Show resolved
Hide resolved
AThousandShips
force-pushed
the
lambda_arg_fix
branch
from
July 5, 2024 08:38
5b27850
to
56a1fd1
Compare
Will check the difference with self and non-self callables and check both for completeness, will update in a bit when I've confirmed the cases Edit: Done |
AThousandShips
force-pushed
the
lambda_arg_fix
branch
from
July 5, 2024 08:51
56a1fd1
to
7b0cb2f
Compare
dalexeev
reviewed
Jul 5, 2024
modules/gdscript/tests/scripts/runtime/features/lambda_bind_argument_count.gd
Outdated
Show resolved
Hide resolved
AThousandShips
force-pushed
the
lambda_arg_fix
branch
from
July 5, 2024 11:39
7b0cb2f
to
e6d98f0
Compare
The tests are overcomplicated, you can simply use: var a: int
var lambda := func (x: int) -> void:
print(a, x)
print(lambda.get_argument_count()) # Should print 1, prints 2 in master. |
Sure, can remove the extra cases, but will keep separate cases for self/non-self to get full coverage Edit: will redo the test one moment |
AThousandShips
force-pushed
the
lambda_arg_fix
branch
from
July 5, 2024 11:50
e6d98f0
to
7beb86c
Compare
AThousandShips
force-pushed
the
lambda_arg_fix
branch
from
July 5, 2024 11:54
7beb86c
to
aa28782
Compare
dalexeev
approved these changes
Jul 5, 2024
Thanks! |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.