Fix GDScript analyzer error when instantiating EditorPlugins. #93942
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeSchulze Since the original author doesn't respond for several days, feel free to continue their work (the original PR has some unresolved suggestions). |
|
@dalexeev done, can you assign the pr to me please? |
|
Ready for review |
There was a problem hiding this comment.
Looks good to me and it fixes the bug.
There are some inconsistencies between is_abstract() and is_virtual(). I think in the future we should remove #ifdef TOOLS_ENABLED code and the !ti->disabled check from is_virtual(), but for now let's leave it as is.
@MikeSchulze Please squash commits into one according to our PR workflow. Make sure you are the commit author and @baptr is a co-author (or vice versa).
Editor code is not instantiable outside of the editor (https://github.com/godotengine/godot/blob/1d14c054a12dacdc193b589e4afb0ef319ee2aae/core/object/class_db.cpp#L369). This is fine for editor plugins and the like, but the GDScript analyzer balks at it, causing F5 runs to fail: godotengine#73525. Instead, we really just want to know if the type is abstract - so add a new ClassDB method to check that and nothing else. Update core/object/class_db.cpp Apply code review comments Co-Authored-By: Bryce <[email protected]>
|
@dalexeev done |
There was a problem hiding this comment.
Note that you are still not the commit author:
Also please do not use GitHub links in commit messages in the future, see CONTRIBUTING.md:
If your commit fixes a reported issue, please include it in the description of the PR (not in the title, or the commit message) using one of the GitHub closing keywords such as "Fixes #1234". This will cause the issue to be closed automatically if the PR is merged. Adding it to the commit message is easier, but adds a lot of unnecessary updates in the issue distracting from the thread.
akien-mga
changed the title
|
Thanks! |
Continue from originally #74025