Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush delete queue after process frame timers #93871

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 2, 2024

Same as #85674

@akien-mga
Copy link
Member

Oof, sad that I missed this one until now despite having approved its predecessor and suggested it for early 4.4... #85674 (review)

Now we're again at the stage where such change might be too risky just before beta...
Unless some core folks can confirm this seems safe enough, CC @RandomShaper @hpvb.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to merge and get this tested, but "when" is still TBD.

@akien-mga akien-mga requested a review from a team January 7, 2025 22:12
@RandomShaper
Copy link
Member

RandomShaper commented Jan 8, 2025

Sorry?
image

The mentioned unicode code point turns out to be the toilet emoji! Very appropriate for a PR related to deleting and flushing, but still... I don't know where those characters are supposed to be.

@Zireael07
Copy link
Contributor

Look at the line just above the warning (KoBeWi wants to merge one commit into godotengine:master from...)

@RandomShaper
Copy link
Member

Looks safe to me. Also, it matches what it's documented for Node.queue_free().

The only source of issues I can think of is potential friction with users relying on the former, inconsistent behavior.

@akien-mga akien-mga merged commit 1100771 into godotengine:master Jan 11, 2025
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the 🚽🚽 branch January 11, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants