Fix parsing of 4. in Expression
#93856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
force-pushed
the
expression-period
branch
from
39fbf6b to
ee9cea5
Compare
timothyqiu
added
the
cherrypick:4.3
lawnjelly
approved these changes
Sep 10, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92895
Expressionhas a bug handling numbers at the end of an expression. It always puts the last character back in the stream.Unlike other unexpected characters, reading an end-of-string does not move the cursor, so we should not move the cursor back in this case.
For example
1e5should produce two tokensCONSTANT(10000)andEOF, but it's actually three tokensCONSTANT(10000),CONSTANT(5)andEOF. A standalone4.is similar, it was parsed intoCONSTANT(4.0),PERIOD, andEOF. This sequence is invalid, thus the error.