Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Fix get_property_list get wrong order of properties #93779

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

hayahane
Copy link
Contributor

Fixes #70146
CSharpInstance add the properties to the properties list in a wrong order.

@hayahane hayahane requested a review from a team as a code owner June 30, 2024 11:55
@AThousandShips AThousandShips added this to the 4.4 milestone Jun 30, 2024
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission!

Looks good to me, and fits the GDScript behaviour.

@akien-mga akien-mga merged commit 40d8d82 into godotengine:master Sep 13, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_GetPropertyList() in CSharp has different behavior with _get_property_list() in GDScript
5 participants