Change GUI controls pixel snap to round halfway towards positive infinity (floor(x + 0.5))
#93749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alvinhochun! Congrats for your first PR, and welcome! I created an MRP based on the one you created for #93731, and it seems to exhibit the same issue for Controls without your PR. With yours, it seems to fix the issue. Here it is: I tested Catburglar with it and it doesn't seem to cause any visible issues. I'll continue testing for possible issues on GUI intensive games. But at first glance, it seems like a welcome addition for 4.3. Thanks again! |
|
CC @markdibarry |
markdibarry
approved these changes
Jul 17, 2024
akien-mga
approved these changes
Jul 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same thing as #93740 but for GUI controls, for consistency.