Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max width for icons in the quick open popup #93743

Merged

Conversation

poga
Copy link
Contributor

@poga poga commented Jun 29, 2024

This fix #93690.

@AThousandShips AThousandShips modified the milestones: 4.4, 4.3 Jun 29, 2024
@akien-mga akien-mga requested a review from a team June 29, 2024 15:16
@poga poga force-pushed the 93690-fix-quickopen-icon-max-width branch from 75efaac to 9bd3163 Compare June 29, 2024 15:35
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits need to be squashed.

@poga poga force-pushed the 93690-fix-quickopen-icon-max-width branch from 81fa029 to f6e6cd3 Compare June 29, 2024 16:37
@poga
Copy link
Contributor Author

poga commented Jun 29, 2024

Squashed!

@poga poga force-pushed the 93690-fix-quickopen-icon-max-width branch from f6e6cd3 to 77c3313 Compare June 29, 2024 16:56
@akien-mga akien-mga changed the title Fix: set max_width for icons in the quick open popup Set max width for icons in the quick open popup Jun 29, 2024
@akien-mga akien-mga merged commit 37ea017 into godotengine:master Jun 29, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@z4gon
Copy link

z4gon commented Jun 29, 2024

Thank you for the fix!

@poga poga deleted the 93690-fix-quickopen-icon-max-width branch June 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom SVG icon appears too large in Quick Open (Ctrl+P)
5 participants