Fix support for environment blend modes on WebXRInterface
#93646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malcolmnixon
approved these changes
Jun 27, 2024
BastiaanOlij
approved these changes
Jun 27, 2024
dsnopek
force-pushed
the
webxr-environment-blend-mode
branch
from
85608b0 to
2f001e6
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with XR Tools, @Malcolmnixon noticed that
WebXRInterfacewas not returning the correct environment blend mode when using"immersive-ar". This PR aims to fix that!Unfortunately,
XRSession.environmentBlendModeisn't implemented on all browsers (namely, Firefox and Safari, according to MDN), so it will fallback on some guesses, if necessary.I've tested in the Meta Quest browser.