NavigationServer3D.map_get_closest_point_to_segment - add an additional shortest distance check
#93541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
NavigationServer3D.map_get_closest_point_to_segment- added an additional shortest distance checkNavigationServer3D.map_get_closest_point_to_segment- add an additional shortest distance check
kleonc
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
LGTM! 👍
It would also be good to add test cases (in test_navigation_server_3d.h? 🤔) which:
- would fail before Fix closest edge and face check in
NavigationServer3D.map_get_closest_point_to_segment#93227, - would fail between Fix closest edge and face check in
NavigationServer3D.map_get_closest_point_to_segment#93227 and this PR.
…al shortest distance check For a case when shortest distance is between some point located on a face's edge and some point located on a line segment.
akien-mga
force-pushed
the
fixing-navmap-pr
branch
from
29d9ca8 to
b8fc6b4
Compare
akien-mga
changed the title
NavigationServer3D.map_get_closest_point_to_segment- add an additional shortest distance checkNavigationServer3D.map_get_closest_point_to_segment - add an additional shortest distance check
|
I rebased the PR to squash the commits and shorten the commit title a bit. I suggest adding tests in a follow up PR so we can get this fix merged for now, or we risk forgetting about it :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional shortest distance check for a case when shortest distance is between some point located on a face's edge and some point located on a line segment (thx for the tip @kleonc).
This is an additional fix to this PR #93227. The fix is pretty naive, but it seems to be working:
@smix8 @kleonc