Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brief description tooltips to EditorResourcePicker #93523

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add brief description tooltips to EditorResourcePicker #93523

merged 1 commit into from
Jun 24, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 23, 2024

tooltips.mp4

The implementation is very simple, so why not.

@KoBeWi KoBeWi added this to the 4.x milestone Jun 23, 2024
@KoBeWi KoBeWi force-pushed the a_feature_nobody_wanted_and_also_nobody_needed branch from f6b6f97 to 8cdd740 Compare June 23, 2024 20:43
Mickeon
Mickeon reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly simple. As discussed in RocketChat, it's better than not having the tooltip at all.
Note that the tooltip does not support BBCode formatting at all, but it's not an issue exclusive to the resource picker.

@JekSun97
Copy link
Contributor

the value is taken from the documentation, as I understand it, the translation will not be applied?

@Mickeon
Copy link
Contributor

Mickeon commented Jun 24, 2024

They would, assuming the brief description is localized by the translators, which unfortunately is not a given.

@KoBeWi KoBeWi force-pushed the a_feature_nobody_wanted_and_also_nobody_needed branch from 8cdd740 to 40be5c4 Compare June 24, 2024 13:09
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 24, 2024
@akien-mga akien-mga merged commit 2542a07 into godotengine:master Jun 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@Mickeon Mickeon Mickeon approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@KoBeWi @JekSun97 @Mickeon @akien-mga @AThousandShips