Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical separation to audio bus #93507

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

passivestar
Copy link
Contributor

Makes spacing more consistent with the rest of the editor. "6" almost touching the top line was especially noticeable

Before After
before after

@Mickeon
Copy link
Contributor

Mickeon commented Jun 23, 2024

Personal peeve, although the separation is good, I think it's a bit too much. Although it really puts to question the existing design, the effects list has even less breathing room in this PR.

@passivestar
Copy link
Contributor Author

Personal peeve, although the separation is good, I think it's a bit too much. Although it really puts to question the existing design, the effects list has even less breathing room in this PR

It's around the same size as other gaps:

image

I think if the effects list is a concern the volume meter should be shortened, not the gaps. Inconsistent gaps look scuffed

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 25, 2024
@akien-mga akien-mga merged commit 9334068 into godotengine:master Jun 25, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the bus-v-space branch June 25, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants