Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect text in ResourceImporterWAV description #93497

Merged

Conversation

Meorge
Copy link
Contributor

@Meorge Meorge commented Jun 23, 2024

The descriptions for the edit/loop_begin and edit/loop_end members now correctly state that the units are samples, rather than seconds.

@Meorge Meorge requested a review from a team as a code owner June 23, 2024 02:18
@Mickeon
Copy link
Contributor

Mickeon commented Jun 23, 2024

The translation files are automatically generated. You do not need to and should not modify them.

@Mickeon Mickeon added this to the 4.3 milestone Jun 23, 2024
@Meorge Meorge force-pushed the fix_wav_import_loop_samples_docs branch from 4a41f90 to 00c7aa5 Compare June 23, 2024 14:39
@Meorge
Copy link
Contributor Author

Meorge commented Jun 23, 2024

Got it, thanks! I reset my branch to before the commit that modified the translation files and force-pushed that to the branch so that it shouldn't have the changes done and then undone in thie history. Hopefully that's okay! 😅

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as the end result is one commit in the PR it's all good!

As for the documentation mistake, I'm surprised it wasn't caught sooner because it's pretty damningly incorrect.

@Mickeon Mickeon added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 23, 2024
The descriptions for the edit/loop_begin and edit/loop_end members now
correctly state that the units are samples, rather than seconds.
@akien-mga akien-mga force-pushed the fix_wav_import_loop_samples_docs branch from 00c7aa5 to 13f7f41 Compare June 24, 2024 15:47
@akien-mga akien-mga changed the title Fix incorrect text in ResourceImporterWAV Fix incorrect text in ResourceImporterWAV description Jun 24, 2024
@akien-mga akien-mga merged commit c5260fb into godotengine:master Jun 24, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants