Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on shader constant initialization on MinGW compiler #93469

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 22, 2024

Fix #93387 (only the crash, the constants parsing should be rewritten in future). As a workaround, it works.

@Chaosus Chaosus requested a review from a team as a code owner June 22, 2024 13:23
@Chaosus Chaosus added this to the 4.3 milestone Jun 22, 2024
@Chaosus Chaosus force-pushed the shader_fix_crash branch 3 times, most recently from 74f0426 to b59bceb Compare June 22, 2024 13:36
@Chaosus Chaosus changed the title Fix shader crash at constant initialization on MinGW compiler Fix editor crash on shader constant initialization on MinGW compiler Jun 22, 2024
@Chaosus Chaosus force-pushed the shader_fix_crash branch from b59bceb to d5b393a Compare June 22, 2024 13:37
@Chaosus Chaosus changed the title Fix editor crash on shader constant initialization on MinGW compiler Fix crash on shader constant initialization on MinGW compiler Jun 22, 2024
@Chaosus
Copy link
Member Author

Chaosus commented Jun 23, 2024

@matheusmdx would you like to check it?

@matheusmdx
Copy link
Contributor

Cherry-picked on latest master and i can confirm this stop the crash

@akien-mga akien-mga merged commit 2e8ebb4 into godotengine:master Jun 25, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_fix_crash branch June 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants