Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying selected Bezier animation keys in inspector #93408

Merged

Conversation

CookieBadger
Copy link
Contributor

@CookieBadger CookieBadger commented Jun 20, 2024

fixes #93308 and other regressions regarding displaying selected bezier animation keys in the inspector.

Unfortunately, this fix was not as simple, as selecting keys was not handled correctly across almost all features of the bezier editor. For example, handling multiple selected keys in the inspector was implemented, but there were some bugs not allowing the feature to work or throw errors during editing.

With this fix, key selection should be consistent across the animation UI and the inspector with all operations (selecting with click/shift-click/box/shortcut, deselecting, inserting, copying/duplicating, etc.). I would appreciate any help testing if there is another way to get inspector and animation UI to disagree in their selection that I might have missed.

EDIT: just discovered this also fixes #29155, although a backport to 3.x might not be a bad idea.

@CookieBadger CookieBadger force-pushed the animation-track-key-inspector-fix branch from 441c9ef to 2b8b21c Compare June 21, 2024 10:30
@akien-mga akien-mga changed the title Fix Displaying Selected Bezier Animation Keys in Inspector Fix displaying selected Bezier animation keys in inspector Jun 21, 2024
@fire fire requested a review from TokageItLab June 27, 2024 15:47
@clayjohn clayjohn requested a review from KoBeWi June 27, 2024 15:48
@akien-mga akien-mga requested a review from Calinou June 27, 2024 15:49
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@akien-mga akien-mga merged commit eeef96b into godotengine:master Jun 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants