Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual shader not being updated when switching tabs #93385

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix visual shader not being updated when switching tabs #93385

merged 1 commit into from
Jun 20, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 20, 2024

Fix #93383

@Chaosus Chaosus requested a review from a team as a code owner June 20, 2024 10:38
@Chaosus Chaosus added this to the 4.3 milestone Jun 20, 2024
@akien-mga akien-mga merged commit acb9a4e into godotengine:master Jun 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_fix_updating branch June 20, 2024 15:45
@aaronfranke
Copy link
Member

Thanks, this helps with #92576 (making the visual shader and text shader APIs more similar to each other).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Visual shader is not updated when switching between tabs, which lead to bugs
3 participants
@Chaosus @akien-mga @aaronfranke