GDScript: Fix non-global class export #93384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 20, 2024
dalexeev
force-pushed
the
gds-fix-non-global-class-export
branch
from
ef22d75 to
24b6edc
Compare
akien-mga
approved these changes
Jun 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, the current behavior is not a regression, we just added missing validation for an already existing and documented limitation. But since this breaks plugins (which often try to avoid
class_name), I tried to fix it as suggested: when exporting a non-global class property, GDScript looks for the nearest global/native class, rather than throwing an analyzer error.