Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup order in unregister_core_types() #93293

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix cleanup order in unregister_core_types() #93293

merged 1 commit into from
Jun 18, 2024

Conversation

rune-scape
Copy link
Contributor

ResourceCache::clear() can use Object::get_class() which is cleaned up by ClassDB::cleanup() need to rearrange

@rune-scape rune-scape requested a review from a team as a code owner June 18, 2024 07:48
lawnjelly
lawnjelly approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible (providing there are no regressions, my crystal ball gazing not working this morning). 😁

@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Jun 18, 2024
akien-mga
akien-mga approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems relatively safe from looking at what ResourceCache::clear() actually does.

@akien-mga akien-mga merged commit 470cc59 into godotengine:master Jun 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rune-scape rune-scape deleted the cleanup-order branch June 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@rune-scape @akien-mga @lawnjelly @AThousandShips