Fix force continuous with un-interpolatable value is not applied correctly #93185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
added
bug
topic:animation
cherrypick:4.2
TokageItLab
force-pushed
the
fix-force-continuous
branch
from
8757f21 to
049c1a5
Compare
fire
approved these changes
Jun 15, 2024
|
Thanks! |
TokageItLab
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The un-interpolatable value is forced into discrete mode by the constraints previously described in godotengine/godot-proposals#8085, but it was exclusive of the conversion by force continous. Force continous needs to take precedence over everything else, so I fixed the branching about it.