Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crypto] Expose get_system_ca_certificates. #93176

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[Crypto] Expose get_system_ca_certificates. #93176

merged 1 commit into from
Jun 17, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jun 14, 2024

So that custom TLS and HTTP clients can use the Godot OS API to read the system certificates.

@Faless Faless requested review from a team as code owners June 14, 2024 20:29
@AThousandShips AThousandShips added this to the 4.x milestone Jun 14, 2024
Calinou
Calinou approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and docs look good to me.

@akien-mga akien-mga changed the title [Crypto] Expose get_system_ca_certificates. [Crypto] Expose get_system_ca_certificates. Jun 17, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 17, 2024
@akien-mga akien-mga merged commit 8cbe4fb into godotengine:master Jun 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the crypto/expose_get_system_ca_certificates branch June 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:core topic:network
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Faless @akien-mga @Calinou @AThousandShips