Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion: Add support for string name option in more places #93057

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

HolonProduction
Copy link
Member

Fixes #93034

#66481 missed some code paths for special cases of argument options which are handled by the autocompletion.

Those cases now also consistently add the quotes to the preview which is in line with how we handle the default argument options. 'What you see is what you get', makes sense in this place.

Also adds test for most of the special code paths. The autoload code path is hard to test right now, since adding autoloads changes the output of Node.print_orphan_nodes which is used by some other unit tests. I will look into that separately.

@HolonProduction HolonProduction requested a review from a team as a code owner June 11, 2024 20:35
@dalexeev dalexeev added this to the 4.3 milestone Jun 12, 2024
@akien-mga akien-mga merged commit cd87b0b into godotengine:master Jun 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@HolonProduction HolonProduction deleted the not-enough-code-paths branch October 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion does not always add StringNames when it should
3 participants