Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find highlight when switching scripts #93056

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix find highlight when switching scripts #93056

merged 1 commit into from
Jun 28, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Jun 11, 2024

Highlights when switching to another editor.
Stops highlighting when switching away.

@kitbdev kitbdev requested a review from a team as a code owner June 11, 2024 19:59
@YeldhamDev YeldhamDev added this to the 4.3 milestone Jun 11, 2024
@kitbdev kitbdev mentioned this pull request Jun 27, 2024
Merged
akien-mga
akien-mga approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 89cf82f into godotengine:master Jun 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the stop-highlighting branch June 28, 2024 12:39
@kitbdev kitbdev mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinyangcruise jinyangcruise jinyangcruise left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Script editor find highlight gets stuck when find panel is closed in another tab
4 participants
@kitbdev @akien-mga @jinyangcruise @YeldhamDev