Editor: Warn on UID duplicates #92972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
This commonly occurs when files are copied outside of the editor and don't get new UIDs. Restricting this warning to first_scan since it's we want to exclude the case of files being moved after initial load which is harder to handle. Addresses godotengine/godot-proposals#8949
ogapo
force-pushed
the
pr/warn-on-duplicate-uids
branch
from
2ddd55b to
5122a3e
Compare
|
Would love this to be brought in. As a beginner UIDs in general are not common knowledge, or mentioned in learning resources, leading to a lot of confusion and time wasted when UID conflicts are the source of problems. Would it make sense to include in the warning how to go about fixing the issue, when it is detected? |
RandomShaper
approved these changes
Jun 19, 2024
AThousandShips
approved these changes
Sep 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commonly occurs when files are copied outside of the editor and don't get new UIDs.
Restricting this warning to first_scan since we want to exclude the case of files being moved after initial load which is harder to handle.
Closes godotengine/godot-proposals#8949