Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Improve BBCode parsing. #92962

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[RTL] Improve BBCode parsing. #92962

merged 1 commit into from
Sep 6, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 10, 2024

See #92749 (comment)

  • Use OptionMap for all tags.
  • Add support for spaces and ] in the quoted portion of BBCode subtag.
  • Replace some hardcoded offsets with find.

@bruvzg bruvzg added this to the 4.x milestone Jun 10, 2024
@bruvzg bruvzg force-pushed the rtl_bbcode_parsing branch 4 times, most recently from 4d5d1f0 to 27dd9e2 Compare June 13, 2024 08:10
@bruvzg bruvzg marked this pull request as ready for review June 13, 2024 08:11
@bruvzg bruvzg requested a review from a team as a code owner June 13, 2024 08:11
Calinou
Calinou approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with https://github.com/Calinou/godot-endoom and https://github.com/godotengine/godot-demo-projects/tree/master/gui/rich_text_bbcode, it works as expected. Performance is the same as before.

Code looks good to me.

@bruvzg bruvzg force-pushed the rtl_bbcode_parsing branch from 27dd9e2 to 51a5791 Compare June 20, 2024 05:41
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 6, 2024
@akien-mga
Copy link
Member

Might benefit from a rebase before merging, just to make sure it still builds.

@bruvzg bruvzg force-pushed the rtl_bbcode_parsing branch from 51a5791 to b59fd28 Compare September 6, 2024 11:09
@akien-mga akien-mga merged commit d000faa into godotengine:master Sep 6, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @akien-mga @Calinou @KoBeWi