Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio stream polyphonic #92852

Closed
wants to merge 510 commits into from
Closed

Audio stream polyphonic #92852

wants to merge 510 commits into from

Conversation

ditiem-games
Copy link

This changes are for 4.2.2-stable.

Tested with my own game and works as expected.

The bug in the code happens because the index of the streams is recorded in the returned ID:

return (ID(i) << INDEX_SHIFT) | ID(streams[i].id);

Whenever an stream is deleted, or the returned ID is stored in gdscript and some other stream replaces the old (non active) one, things will go wrong.

akien-mga and others added 30 commits March 11, 2024 15:00
(cherry picked from commit 6fa77e0)
(cherry picked from commit 72b80b3)
ReShade can still be used on projects run from the editor as well
as exported projects.

This avoids several issues:

- ReShade doesn't play well with low-processor mode, making it hard
  to use unless the Update Continuously editor setting is enabled.
- The ReShade overlay appears on every popup opened, which made popups
  unusable.
- If you use a ReShade configuration that heavily affects the image,
  it won't affect the editor UI which may become unreadable as a result.

This doesn't affect the editor being run via OpenGL or Direct3D 12
as ReShade is injected in a different manner when using those graphics
APIs.

(cherry picked from commit 67b8d71)
(cherry picked from commit ab14dec)
(cherry picked from commit 41268d7)
Global position doesn't get adjusted within `InputEventMouse::xformed_by()`.

(cherry picked from commit 8de3991)
Handle the case correctly, that a child of a replaced node has
as owner an ancestor of the replaced node.

(cherry picked from commit c58607c)
…are good enough when using compression

(cherry picked from commit 781cd27)
In NavigationPolygon use PROPERTY_HINT_LAYERS_2D_PHYSICS instead of PROPERTY_HINT_LAYERS_3D_PHYSICS to display the correct property hints.

Fixes #88154.

(cherry picked from commit 0831ea0)
@Chaosus Chaosus removed request for a team June 8, 2024 15:42
@Calinou
Copy link
Member

Calinou commented Jun 10, 2024

@ditiem-games Is there an associated bug report? If not, I suggest opening one.

Also, your PR was closed as you accidentally rebased your branch over master, which caused you to pull in a lot of unrelated commits. You should open a new pull request with only a single commit included over master.

@ditiem-games ditiem-games deleted the audio_stream_polyphonic branch June 13, 2024 06:49
@ditiem-games
Copy link
Author

@ditiem-games Is there an associated bug report? If not, I suggest opening one.

Also, your PR was closed as you accidentally rebased your branch over master, which caused you to pull in a lot of unrelated commits. You should open a new pull request with only a single commit included over master.

Ok, I retry. Here is the pull request.

#93120

The bug fixed is in the comment (as it was before):
#86053

Hope it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.