Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Activate Process leading to stuck input #92742

Merged

Conversation

Hilderin
Copy link
Contributor

@Hilderin Hilderin commented Jun 3, 2024

I was able to reproduce the problem of key being stuck after Alt-Tab everything time after the editor windows moved.
The problem was caused by the move_timer_id that was not resetted and was stucked with same value of the activate_timer_id preventing the _process_activate_event from executing.

Godot 4.3 beta 1:

Godot_v4.3-beta1_win64_G0bbOp6EAi.mp4

After the fix:

godot.windows.editor.dev.x86_64_rag0uDhgEG.mp4

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the issue, but this change is definitely correct. SetTimer can reuse IDs and since we can have multiple times per window, not unsetting it might cause interference.

@akien-mga akien-mga merged commit e96ad5a into godotengine:master Jun 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment