Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Expose some helper methods on Viewport #92573

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

timothyqiu
Copy link
Member

Backports #57517 & #85966

Adds these three methods to Viewport:

  • gui_release_focus()
  • gui_get_focus_owner()
  • gui_get_hovered_control()

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some testing

doc/classes/Viewport.xml Outdated Show resolved Hide resolved
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
Expose gui_release_focus and gui_get_focus_owner to Viewport
Expose a method to get hovered Control in Viewport

Co-Authored-By: Gilles Roudiere <[email protected]>
Co-Authored-By: Claire Blackshaw <[email protected]>
@timothyqiu timothyqiu force-pushed the viewport-expose-3.x branch from 70e9a51 to 35b7a49 Compare June 28, 2024 14:12
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is fine now and aside it's mostly identical to master. Again, could use some testing.

@timothyqiu
Copy link
Member Author

@Mickeon 3.x does not have Viewport related tests. Should I try to add them?

@Mickeon
Copy link
Contributor

Mickeon commented Jun 28, 2024

I don't mean those kind of tests 💦, I'm not sure if 3.x even has any support for them. I just mean giving the methods a test run to see if they are working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants