Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using built-ins for func names in shaders #92564

Merged

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 30, 2024

Using built-in functions for function names are incorrect - the code won't allow calling such function (and it won't in GLSL):

изображение

but currently it will not emit error if user not calling such function:

изображение

after this fix it will:

изображение

Note: other use cases for built-in names such as constants, variables and function arguments are still be valid and untouched.

@Chaosus Chaosus requested a review from a team as a code owner May 30, 2024 18:20
@Chaosus Chaosus added this to the 4.3 milestone May 30, 2024
@Chaosus Chaosus force-pushed the shader_prevent_override_builtin_funcs branch from fa5aaf1 to aecc4cb Compare May 30, 2024 18:33
@akien-mga akien-mga merged commit 7ba29c0 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_prevent_override_builtin_funcs branch May 31, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants