Ensure that Godot's version of libc++_shared.so is always selected
#92525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case dependencies have their own
akien-mga
approved these changes
May 29, 2024
Comment on lines
+129
to
+132
| pickFirst 'lib/x86/libc++_shared.so' | ||
| pickFirst 'lib/x86_64/libc++_shared.so' | ||
| pickFirst 'lib/armeabi-v7a/libc++_shared.so' | ||
| pickFirst 'lib/arm64-v8a/libc++_shared.so' |
There was a problem hiding this comment.
I'm assuming there's gradle logic to still handle the arch properly only "pickFirst" the one that actually matches the target arch?
There was a problem hiding this comment.
yes, this specifies a pattern and so it picks the ones that match the given patterns.
akien-mga
changed the title
libc++_shared.so is always selected
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves collision issues in case dependencies have their own version.