Prevent static XCFramework bundles from being embedded on iOS #92519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when archiving/distributing iOS apps that utilize extensions that have been built with the XCFramework approach, as seen in godot-cpp's
testproject here, you will currently run into errors when you try to validate said app, due to the.afiles of the two XCFramework bundles (godot-cpp and the extension) being bundled within the.app.This PR fixes this by checking to see whether the XCFramework only contains static libraries before respecting
IOSExportAsset::should_embed, same as what regular frameworks already do as of #86288, as seen a few lines above this change.CC @bruvzg