Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate Control global transform before notifying about resize / rect change #92489

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented May 28, 2024

Fixes #92449 (as far as I've tested).

Moved only _notify_transform() so the order of NOTIFICATION_RESIZED / item_rect_changed signal remains unchanged.

@kleonc kleonc added bug topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 28, 2024
@kleonc kleonc added this to the 4.3 milestone May 28, 2024
@kleonc kleonc requested a review from Sauermann May 28, 2024 20:00
@kleonc kleonc requested a review from a team as a code owner May 28, 2024 20:00
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me

scene/gui/control.cpp Outdated Show resolved Hide resolved
@kleonc kleonc force-pushed the control-invalidate-global-transform-before-notifying-resize branch from 9ed7100 to 22b6f96 Compare May 30, 2024 08:17
@akien-mga akien-mga merged commit adbc4b0 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the control-invalidate-global-transform-before-notifying-resize branch May 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling get_global_rect() inside an item_rect_changed callback behaves inconsistently
3 participants