[3.x] Physics Interpolation - 3D shifting origin support #92469
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
force-pushed
the
fti_3d_autoreset
branch
from
33296d3 to
7138f60
Compare
lawnjelly
changed the title
lawnjelly
force-pushed
the
fti_3d_autoreset
branch
from
7138f60 to
ca8439d
Compare
Calinou
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Tested locally on https://github.com/godotengine/godot-demo-projects/tree/3.x/3d/kinematic_character, it works as expected.
Before
Both videos use 4x slowdown and 10 physics ticks per second.
reset_before.mp4
After
reset_after.mp4
Calinou
reviewed
Jun 6, 2024
doc/classes/VisualServer.xml
Outdated
Comment on lines
132
to
134
| Transforms both the current and previous stored transform for a camera. | ||
| This allows transforming a camera without creating a "glitch" in the interpolation. | ||
| This is particularly useful for large worlds utilising a shifting origin. |
There was a problem hiding this comment.
Each linebreak creates a new paragraph (which takes space), so I think this makes more sense as a single paragraph:
Suggested change
| Transforms both the current and previous stored transform for a camera. | |
| This allows transforming a camera without creating a "glitch" in the interpolation. | |
| This is particularly useful for large worlds utilising a shifting origin. | |
| Transforms both the current and previous stored transform for a camera. This allows transforming a camera without creating a "glitch" in the interpolation. This is particularly useful for large worlds utilising a shifting origin. |
Calinou
reviewed
Jun 6, 2024
doc/classes/VisualServer.xml
Outdated
Comment on lines
1622
to
1624
| Transforms both the current and previous stored transform for an instance. | ||
| This allows transforming an instance without creating a "glitch" in the interpolation. | ||
| This is particularly useful for large worlds utilising a shifting origin. |
There was a problem hiding this comment.
Suggested change
| Transforms both the current and previous stored transform for an instance. | |
| This allows transforming an instance without creating a "glitch" in the interpolation. | |
| This is particularly useful for large worlds utilising a shifting origin. | |
| Transforms both the current and previous stored transform for an instance. This allows transforming an instance without creating a "glitch" in the interpolation. This is particularly useful for large worlds utilising a shifting origin. |
Calinou
reviewed
Jun 6, 2024
scene/3d/camera.cpp
Outdated
| @@ -121,6 +121,13 @@ void Camera::_notification(int p_what) { | |||
| if (doppler_tracking != DOPPLER_TRACKING_DISABLED) { | |||
| velocity_tracker->update_position(get_global_transform().origin); | |||
| } | |||
|
|
|||
| // Auto-reset when first adding to the tree, as a convenience. | |||
There was a problem hiding this comment.
Suggested change
| // Auto-reset when first adding to the tree, as a convenience. | |
| // Auto-reset when first adding to the tree, as a convenience. |
|
Just making this draft temporarily as I've moved some of the auto-reset functionality to #92784. (Otherwise it is impossible to keep the changes in sync). I'll probably edit this PR to include just the moving origin support as that is fairly self-contained. |
lawnjelly
force-pushed
the
fti_3d_autoreset
branch
from
ca8439d to
ec2d2cb
Compare
lawnjelly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance_transform_physics_interpolation().Discussion
Once auto-resets are added for 3D, it becomes necessary to add explicit support for moving origins, as moving origin worlds (for large world support) cannot be achieved easily without this.
ToDo
Still need to add support to call the
VisualServerfunctions fromVisualInstance, and supportCameras(which will work differently as of #92784).