Fix -empty string- console log in web export (cosmetic) #92468
Conversation
| @@ -2841,8 +2841,10 @@ Error Main::setup2() { | |||
|
|
|||
| OS::get_singleton()->benchmark_end_measure("Startup", "Servers"); | |||
|
|
|||
| #ifndef WEB_ENABLED | |||
| // Add a blank line for readability. | |||
| Engine::get_singleton()->print_header(""); | |||
There was a problem hiding this comment.
Is Engine::get_singleton()->print_header(" "); (space instead of empty) working in web export, or it will do the same? It's probably better to actually have a blank line, and should work on all platforms.
There was a problem hiding this comment.
The inserted space removes the appearance of the ‘empty string’ message.
This is the simplest solution (1-character commit 🙄), on the other hand, in the case of the browser console, usually each separate line of the log means something, hence my search for the source of the message (I thought the engine was trying to communicate something but the content was missing).
There was a problem hiding this comment.
Yeah I think in the context of the browser console it's probably better without the line.
With a single space, the line would appear fine but still be shown as emitted by index.js:15051:16 which defeats the purpose of using it for vertical spacing, as it's now an empty log line with a source (and possibly timestamp I figured out to copy things properly from FF).
|
Thanks! |
Info
While reading the messages displayed by Godot in the browser console, I became interested in what causes the ‘empty string’ message when the engine starts up.
It turned out that the
print_header("")line, which is supposed to improve readability in the terminal window, displays confusing text in the browser (in my case Firefox).Fix
The fix is cosmetic and causes the empty line to display only when WEB_ENABLED is not defined.