-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphEdit] Convert to minimap line after getting connection line. #92463
[GraphEdit] Convert to minimap line after getting connection line. #92463
Conversation
0b7acce
to
6324af0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one problem I have with this solution is that we now need to convert every line point to graph space, not just the start and end point. The minimap is already quite costly.
I'm also unable to reproduce your bug. Could you provide a MRP?
6324af0
to
a70442f
Compare
@Geometror ,here is MRP: Without this pr:With this pr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
a70442f
to
28a2fa4
Compare
Thanks! |
Users can change the start and end position of connection line by overriding
_get_connection_line()
.We should pass the positions in graph to
_get_connection_line()
consistently, then conver the line for minimap.Before:
After: