Implement custom function overloading in shading language #92441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
6 times, most recently
from
efae1f3 to
f0fc098
Compare
|
Okay, I think I've fixed warnings and completion issues, if other users or contributors want to test it extensively please welcome (@paddy-exe, @Calinou, @clayjohn) |
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
3 times, most recently
from
65aebc6 to
5529b79
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
9 times, most recently
from
a321fe2 to
c2b6561
Compare
Chaosus
changed the title
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
2 times, most recently
from
de55ee3 to
02b307c
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
5 times, most recently
from
d1ebf76 to
a5cc0a2
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
3 times, most recently
from
837180a to
a9ada17
Compare
Calinou
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Tested locally in all rendering methods (rebased on top of master a7aa835), it works as expected.
Finally a use case for implicit float → int conversions not being allowed in GLSL. 😛
simplescreenrecorder-2024-06-11_16.51.55.mp4
Testing project: test_pr_92441.zip
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
2 times, most recently
from
a9dc16f to
9be7e72
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
6 times, most recently
from
6d6cf01 to
f0f39ba
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
from
f0f39ba to
b690b21
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
4 times, most recently
from
43e3e9e to
8252027
Compare
Chaosus
force-pushed
the
shader_custom_func_overloads
branch
from
8252027 to
1c86fee
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#2808
Note: in order to prevent ambiguity between function overloading and constant conversion, the constant conversion of similar types will be disabled when the overloads exist on the function call.