Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAP] Add --dap-port as a command line argument #92336

Merged
merged 1 commit into from
May 30, 2024

Conversation

van800
Copy link
Contributor

@van800 van800 commented May 24, 2024

This is very similar to --lsp-port, which was added in #81844

I have started a conversation in https://chat.godotengine.org/channel/devel?msg=qEJuhGNKqXKsxmjZr, however haven't got responses so far.

The PR solves a case, when 2 GodotEditors are opened with projects and external editor tries to use one of the editors for debugging via DAP via Godot Editor (DebugAdapterServer, default port 6006).
In Rider already can start GodotEditor with LSP server in a headless mode, and this PR would help to use such GodotEditor also for debugging. Other external editors, which use DAP may also benefit from the PR.

@van800
Copy link
Contributor Author

van800 commented May 26, 2024

@akien-mga what do you think?

Also I have a question out of scope of this PR.
I have noticed that vscode has its own way to connect directly to the game without using the Editor, is it for historical reasons or is it considered to be more strait-forward usable scenario? If it provides premium usability, why not move DAP server from the Editor to the Engine and remove the necessity to have the Editor running?

@adamscott adamscott modified the milestones: 4.x, 4.3 May 28, 2024
@adamscott adamscott added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label May 28, 2024
@van800 van800 force-pushed the DAP branch 3 times, most recently from 430cb0c to d669553 Compare May 28, 2024 19:59
@akien-mga akien-mga changed the title [DAP] Add --dap-port as a command line argument [DAP] Add --dap-port as a command line argument May 29, 2024
main/main.cpp Outdated Show resolved Hide resolved
main/main.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit cd8bd03 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release enhancement topic:core topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants