Fix reimporting assets with csv in the project

[Hilderin]

This should fix #83200

The problem was that the DebugDialogue.csv.import is invalid according to Godot because it’s missing the path line. Because of this the importer was not mark multithread and a counter was not incremented between threaded and non threaded reimportation. I fixed the increment problem in editor_file_system._reimport_file.

The problem with the invalid .import file was caused because ResourceImporterCSVTranslation is the only importer that has no extension. It does not write any file in the .godot folder. I fixed that adding a check in _get_path_and_type before returning ERR_FILE_CORRUPT.

[akien-mga]

This part seems related to #85130, which I guess aims to address the same issue (albeit in another branch).

I couldn't get full confidence there that the change is correct. Would be good to re-review both PRs conjointly and figure out what this code is trying to do.

CC @RandomShaper @KoBeWi

[Hilderin]

My first tentative was exactly what was done in #85130 but the problem is that the variable 'from' is used elsewere after the Ref<ResourceImporter> importer = ResourceFormatImporter::get_singleton()->get_importer_by_name(reimport_files[from].importer);.

That is how I see it...

In my case I had:
Index 0: threaded = false, importer = csv_translation
Index 1: threaded = true, importer = texture
Index 2: threaded = true, importer = texture
Index 3: threaded = true, importer = texture
Index 4: threaded = false, importer = scene

If I use reimport_files[i].importer :
The first iteration, i = 0 and from = 0, _reimport_file was called directly
The second iteration, i = 1 and from = 0, it tries to start the thread because the importers of index 0 (from) and 2 (i+1) are different which is not was expected:

The thread will be started with the wrong index:

Edited: I looked more closely the comments on the #85130 from @RandomShaper and effectively, there is another potential problem that I did not saw when !importer.is_valid().
I'll look into it.

[AThousandShips]

Referred to this

[Hilderin]

This have been addressed in this commit: 4f55118
I should have been clearer in my comment below.

[Hilderin]

This last commit included modifications to fix #85130 and the comments from @RandomShaper
I added another from = i + 1 if the reimport_file is in groups_to_reimport.
I don't known how to test it, I don't even known what are the groups for importation.

[Hilderin]

I think this could fix at least partially the issue #58131
There were a real problem with the mulithreading when the project contains a csv file or invalid files. In the example of @ryanscottcausecast from #58131 the .import are linked to .stex file that Godot does not recognize. It's maybe linked to another issue with compressed textures?

With the fix, the preview are wrong because they are based on .import files and .godot folder but the texture are working fine:

[AThousandShips]

Haven't tested but the code looks good to me (can't speak for the last line of change that's discussed though)

[Hilderin]

Sorry, @AThousandShips I'm not sure what you are referencing with:

can't speak for the last line of change that's discussed though

Everything should be good, I think.

[akien-mga]

Welp I merged this inadvertently because I was testing it in my master branch before making a merge batch :D

But I guess it's a good way to confirm whether it's working or not, let's see how it fares from now to when I'd need to make beta3 builds.

---

Thanks!