Fix coremidi device index issues #92256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously it was passing the pointer to i, which would be out of scope when events came in to ::read. We actually need to use the void * to hold the value of i, not a reference to i. Using reinterpret to overcome platform issues. NOTE : not tested as no suitable build environment here
small tweak for possible loss of data warning
akien-mga
changed the title
remove casts from loop
|
Anyone able to review this? I would love this to be in an upcoming dev snapshot/beta release as this issue is holding up a project here. |
|
probably not required now due to #90485. Closing. |
|
Thanks for fixing this, even though it was eventually merged from another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #86620
Fixes the device property of the InputEventMIDI being corrupt when using coremidi
Previously it was passing the pointer to i, which would be out of scope when events came in to ::read. We actually need to use the void * to hold the value of i, not a reference to i. Using reinterpret to overcome platform issues. NOTE : not tested as no suitable build environment here