Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate shortcut definitions #92223

Merged
merged 1 commit into from
May 22, 2024
Merged

Remove duplicate shortcut definitions #92223

merged 1 commit into from
May 22, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 21, 2024

Spiritual follow-up to #58847

@KoBeWi KoBeWi added this to the 4.x milestone May 21, 2024
@KoBeWi KoBeWi requested review from a team as code owners May 21, 2024 20:59
fire
fire approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@KoBeWi KoBeWi force-pushed the do_people_really_copy_whole_shortcut_definitions_multiple_times_and_unironically_think_this_is_alright_ branch from 4611dbc to e065d71 Compare May 21, 2024 21:28
akien-mga
akien-mga approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'll merge after beta 1 just in case some difference in order of initialization introduce unexpected breakage.

Edit: Actually YOLO, beta 1 will likely only be on Monday so we have time to test such a (seemingly) benign change.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 21, 2024
@KoBeWi KoBeWi mentioned this pull request May 21, 2024
Merged
@akien-mga akien-mga merged commit 4082288 into godotengine:master May 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the do_people_really_copy_whole_shortcut_definitions_multiple_times_and_unironically_think_this_is_alright_🤔 branch May 22, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:editor topic:input
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @akien-mga @fire