Fix TextureButton's click mask texture size ignored if missing normal texture #92222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
semensanyok
force-pushed
the
fix-TextureButton-click-mask-texture-size-ignored-if-missing-normal-texture
branch
from
4afac19 to
6200f09
Compare
KoBeWi
reviewed
May 25, 2024
KoBeWi
reviewed
May 25, 2024
KoBeWi
reviewed
May 25, 2024
|
I don't like how this makes an empty draw just to calculate texture size 🤔 But it's a pre-existing logic, so for now it works I guess. |
semensanyok
force-pushed
the
fix-TextureButton-click-mask-texture-size-ignored-if-missing-normal-texture
branch
2 times, most recently
from
29a71d2 to
a30229a
Compare
KoBeWi
approved these changes
May 25, 2024
AThousandShips
approved these changes
May 25, 2024
semensanyok
force-pushed
the
fix-TextureButton-click-mask-texture-size-ignored-if-missing-normal-texture
branch
from
a30229a to
63554c7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
although click/hover now works correctly, precisely detecting expected borders, it logs error for abscent "normal" texture.not sure what to do with that message yet, and if it needs to be fixed or not. is error message in case of missing normal texture expected?fixed error log message https://github.com/godotengine/godot/pull/92222/files#diff-d9ffa969dbdabac1b846bcdcddd360802270fcabb040bae52bde2a3ab549c423#241:~:text=%7D%20else%20if%20(texdraw.is_valid())%20%7B