FBX: Change trimming default and use FBX2glTF for compatibility #92197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to check if fixes #90298 (ufbx still imports animations even when turned off in import panel) |
akien-mga
reviewed
May 21, 2024
akien-mga
approved these changes
May 21, 2024
akien-mga
changed the title
ufbx has special logic to handle animation/trimming, and most users expect trimming to be on. For existing projects, we should upgrade files0 to FBX2glTF to preserve node compatibility.
lyuma
force-pushed
the
better_fbx_defaults
branch
from
7f9f770 to
c433754
Compare
No, fixing animation import and bake_fps (both are currently ignored in ufbx) will be a separate PR. |
fire
approved these changes
May 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ufbx has special logic to handle animation/trimming, and most users expect trimming to be on.
For existing projects, we should upgrade files to FBX2glTF to preserve node compatibility.
Not sure if there is a specific issue filed for this, but we discussed both of these issues at the last asset meeting.
Most of the change is enabling the ImportDock to read the compatibility options. The current behavior has Godot confusingly showing the user the default settings even when a file was imported with compatibility. The next import would then overwrite the compatibility options.